[Lldb-commits] [PATCH] Fix segfault notification in lldb-mi

[Ed Maste]

================
Comment at: test/tools/lldb-mi/main.c:15-32
@@ -14,14 +14,20 @@
 int doloop;
+int dosegfault;
 int g_MyVar = 3;
 static int s_MyVar = 4;
 int main (int argc, char const *argv[])
 {
     int a, b;
     printf("argc=%d\n", argc);   //BP_printf_call
     //BP_argctest
     a = a_MyFunction();          //BP_a_MyFunction_call
     b = b_MyFunction();          //BP_b_MyFunction_call
     //BP_localstest -- it must be at line #24 (or fix it in main*.micmds)
     if (doloop) // BP_doloop
         infloop();
+    if (dosegfault)
+    {
+        int *p = NULL;
+        *p = 1;
+    }
     if (argc > 1 && *argv[1] == 'l') {
----------------
ki.stfu wrote:
> clayborg wrote:
> > This should go into a test case binary, probably doesn't belong in the actual MI driver.
> Why? In this case I'm checking that lldb-mi prints the *stopped, so this test relates to MI driver.
I'm guessing it's just a case if mistaken identity. When I first glanced at this in email I spotted only "tools/lldb-mi/main.c" and thought it was the lldb-mi driver itself, not a test for lldb-mi. Perhaps also true for @clayborg.

http://reviews.llvm.org/D7500

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/