[Lldb-commits] [lldb] r228314 - Check-in generated test makefiles

[Zachary Turner]

That's strange, because I definitely remember this happening to me before
(see that thread linked from the other patch review). Maybe something has
changed. If the tree is clean I'm happy though, i will try this patch later
on windows and see what happens.
On Thu, Feb 5, 2015 at 9:15 AM Pavel Labath <labath at google.com> wrote:

> No, the tree should remain "clean".
>
> The current version of the test suite does not delete the makefiles. The
> idea to delete them automatically was my suggestion (which did not go
> through apparently).
>
> On 5 February 2015 at 17:10, Zachary Turner <zturner at google.com> wrote:
>
>> Correct me if I'm wrong, but this doesn't fix the problem right? Now
>> running the test suite will cause git to think files have been deleted. The
>> checked in files need to be named something else, like Makefile.local in my
>> opinion
>>
>> On Thu, Feb 5, 2015 at 9:08 AM Pavel Labath <labath at google.com> wrote:
>>
>>> Author: labath
>>> Date: Thu Feb  5 11:03:22 2015
>>> New Revision: 228314
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=228314&view=rev
>>> Log:
>>> Check-in generated test makefiles
>>>
>>> for rationale, see D7407.
>>>
>>> Added:
>>>     lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/
>>> libcxx/initializerlist/Makefile
>>>     lldb/trunk/test/functionalities/data-formatter/stringprinter/
>>> Makefile
>>>     lldb/trunk/test/functionalities/data-formatter/typedef_array/
>>> Makefile
>>>     lldb/trunk/test/lang/c/struct_types/Makefile
>>>     lldb/trunk/test/python_api/sbvalue_const_addrof/Makefile
>>>
>>> Added: lldb/trunk/test/functionalities/data-
>>> formatter/data-formatter-stl/libcxx/initializerlist/Makefile
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/
>>> functionalities/data-formatter/data-formatter-stl/
>>> libcxx/initializerlist/Makefile?rev=228314&view=auto
>>> ============================================================
>>> ==================
>>> --- lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/
>>> libcxx/initializerlist/Makefile (added)
>>> +++ lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/
>>> libcxx/initializerlist/Makefile Thu Feb  5 11:03:22 2015
>>> @@ -0,0 +1,4 @@
>>> +LEVEL = ../../../../../make
>>> +CXX_SOURCES := main.cpp
>>> +CXXFLAGS += -std=c++11
>>> +include $(LEVEL)/Makefile.rules
>>>
>>> Added: lldb/trunk/test/functionalities/data-formatter/stringprinter/
>>> Makefile
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/
>>> functionalities/data-formatter/stringprinter/
>>> Makefile?rev=228314&view=auto
>>> ============================================================
>>> ==================
>>> --- lldb/trunk/test/functionalities/data-formatter/stringprinter/Makefile
>>> (added)
>>> +++ lldb/trunk/test/functionalities/data-formatter/stringprinter/Makefile
>>> Thu Feb  5 11:03:22 2015
>>> @@ -0,0 +1,4 @@
>>> +LEVEL = ../../../make
>>> +CXX_SOURCES := main.cpp
>>> +CXXFLAGS += -std=c++11
>>> +include $(LEVEL)/Makefile.rules
>>>
>>> Added: lldb/trunk/test/functionalities/data-formatter/typedef_array/
>>> Makefile
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/
>>> functionalities/data-formatter/typedef_array/
>>> Makefile?rev=228314&view=auto
>>> ============================================================
>>> ==================
>>> --- lldb/trunk/test/functionalities/data-formatter/typedef_array/Makefile
>>> (added)
>>> +++ lldb/trunk/test/functionalities/data-formatter/typedef_array/Makefile
>>> Thu Feb  5 11:03:22 2015
>>> @@ -0,0 +1,4 @@
>>> +LEVEL = ../../../make
>>> +CXX_SOURCES := main.cpp
>>> +CXXFLAGS += -std=c++11
>>> +include $(LEVEL)/Makefile.rules
>>>
>>> Added: lldb/trunk/test/lang/c/struct_types/Makefile
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/
>>> c/struct_types/Makefile?rev=228314&view=auto
>>> ============================================================
>>> ==================
>>> --- lldb/trunk/test/lang/c/struct_types/Makefile (added)
>>> +++ lldb/trunk/test/lang/c/struct_types/Makefile Thu Feb  5 11:03:22
>>> 2015
>>> @@ -0,0 +1,3 @@
>>> +LEVEL = ../../../make
>>> +C_SOURCES := main.c
>>> +include $(LEVEL)/Makefile.rules
>>>
>>> Added: lldb/trunk/test/python_api/sbvalue_const_addrof/Makefile
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/
>>> python_api/sbvalue_const_addrof/Makefile?rev=228314&view=auto
>>> ============================================================
>>> ==================
>>> --- lldb/trunk/test/python_api/sbvalue_const_addrof/Makefile (added)
>>> +++ lldb/trunk/test/python_api/sbvalue_const_addrof/Makefile Thu Feb  5
>>> 11:03:22 2015
>>> @@ -0,0 +1,4 @@
>>> +LEVEL = ../../make
>>> +CXX_SOURCES := main.cpp
>>> +CXXFLAGS += -std=c++11
>>> +include $(LEVEL)/Makefile.rules
>>>
>>>
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150205/0bad04b1/attachment.html>