That's strange, because I definitely remember this happening to me before (see that thread linked from the other patch review).  Maybe something has changed.  If the tree is clean I'm happy though, i will try this patch later on windows and see what happens.<br><div class="gmail_quote">On Thu, Feb 5, 2015 at 9:15 AM Pavel Labath <<a href="mailto:labath@google.com">labath@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">No, the tree should remain "clean".<div><br></div><div>The current version of the test suite does not delete the makefiles. The idea to delete them automatically was my suggestion (which did not go through apparently).</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 5 February 2015 at 17:10, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Correct me if I'm wrong, but this doesn't fix the problem right?  Now running the test suite will cause git to think files have been deleted.  The checked in files need to be named something else, like Makefile.local in my opinion<div><div><br><div class="gmail_quote">On Thu, Feb 5, 2015 at 9:08 AM Pavel Labath <<a href="mailto:labath@google.com" target="_blank">labath@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: labath<br>
Date: Thu Feb  5 11:03:22 2015<br>
New Revision: 228314<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228314&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=228314&view=rev</a><br>
Log:<br>
Check-in generated test makefiles<br>
<br>
for rationale, see D7407.<br>
<br>
Added:<br>
    lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/data-formatter-stl/<u></u>libcxx/initializerlist/<u></u>Makefile<br>
    lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/stringprinter/<u></u>Makefile<br>
    lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/typedef_array/<u></u>Makefile<br>
    lldb/trunk/test/lang/c/struct_<u></u>types/Makefile<br>
    lldb/trunk/test/python_api/<u></u>sbvalue_const_addrof/Makefile<br>
<br>
Added: lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/data-formatter-stl/<u></u>libcxx/initializerlist/<u></u>Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/Makefile?rev=228314&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/data-formatter-stl/<u></u>libcxx/initializerlist/<u></u>Makefile?rev=228314&view=auto</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/data-formatter-stl/<u></u>libcxx/initializerlist/<u></u>Makefile (added)<br>
+++ lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/data-formatter-stl/<u></u>libcxx/initializerlist/<u></u>Makefile Thu Feb  5 11:03:22 2015<br>
@@ -0,0 +1,4 @@<br>
+LEVEL = ../../../../../make<br>
+CXX_SOURCES := main.cpp<br>
+CXXFLAGS += -std=c++11<br>
+include $(LEVEL)/Makefile.rules<br>
<br>
Added: lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/stringprinter/<u></u>Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/stringprinter/Makefile?rev=228314&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/stringprinter/<u></u>Makefile?rev=228314&view=auto</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/stringprinter/<u></u>Makefile (added)<br>
+++ lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/stringprinter/<u></u>Makefile Thu Feb  5 11:03:22 2015<br>
@@ -0,0 +1,4 @@<br>
+LEVEL = ../../../make<br>
+CXX_SOURCES := main.cpp<br>
+CXXFLAGS += -std=c++11<br>
+include $(LEVEL)/Makefile.rules<br>
<br>
Added: lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/typedef_array/<u></u>Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/typedef_array/Makefile?rev=228314&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/typedef_array/<u></u>Makefile?rev=228314&view=auto</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/typedef_array/<u></u>Makefile (added)<br>
+++ lldb/trunk/test/<u></u>functionalities/data-<u></u>formatter/typedef_array/<u></u>Makefile Thu Feb  5 11:03:22 2015<br>
@@ -0,0 +1,4 @@<br>
+LEVEL = ../../../make<br>
+CXX_SOURCES := main.cpp<br>
+CXXFLAGS += -std=c++11<br>
+include $(LEVEL)/Makefile.rules<br>
<br>
Added: lldb/trunk/test/lang/c/struct_<u></u>types/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/c/struct_types/Makefile?rev=228314&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/test/lang/<u></u>c/struct_types/Makefile?rev=<u></u>228314&view=auto</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lldb/trunk/test/lang/c/struct_<u></u>types/Makefile (added)<br>
+++ lldb/trunk/test/lang/c/struct_<u></u>types/Makefile Thu Feb  5 11:03:22 2015<br>
@@ -0,0 +1,3 @@<br>
+LEVEL = ../../../make<br>
+C_SOURCES := main.c<br>
+include $(LEVEL)/Makefile.rules<br>
<br>
Added: lldb/trunk/test/python_api/<u></u>sbvalue_const_addrof/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/python_api/sbvalue_const_addrof/Makefile?rev=228314&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/test/<u></u>python_api/sbvalue_const_<u></u>addrof/Makefile?rev=228314&<u></u>view=auto</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lldb/trunk/test/python_api/<u></u>sbvalue_const_addrof/Makefile (added)<br>
+++ lldb/trunk/test/python_api/<u></u>sbvalue_const_addrof/Makefile Thu Feb  5 11:03:22 2015<br>
@@ -0,0 +1,4 @@<br>
+LEVEL = ../../make<br>
+CXX_SOURCES := main.cpp<br>
+CXXFLAGS += -std=c++11<br>
+include $(LEVEL)/Makefile.rules<br>
<br>
<br>
______________________________<u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div>
</blockquote></div>