[Lldb-commits] [PATCH] Fix warning about the use of mktemp and make platform agnostic by adding and using PipeBase::CreateWithUniqueName.

Robert Flack flackr at gmail.com
Wed Feb 4 14:48:49 PST 2015


Updated PipeBase::CreateWithUniqueName to take a SmallVectorImpl<char>& out parameter for the name rather than storing it in the pipe class, reverted the windows pipe name generation since we don't link against the necessary libs yet, and addressed style comments.

Tested on Linux, compiles on Linux and Windows.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7348

Files:
  include/lldb/Host/PipeBase.h
  include/lldb/Host/posix/PipePosix.h
  include/lldb/Host/windows/PipeWindows.h
  source/Host/posix/PipePosix.cpp
  source/Host/windows/PipeWindows.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7348.19354.patch
Type: text/x-patch
Size: 9165 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150204/33021a9a/attachment.bin>


More information about the lldb-commits mailing list