[Lldb-commits] [PATCH] Fix warning about the use of mktemp and make platform agnostic by adding and using PipeBase::CreateWithUniqueName.

[Oleksiy Vyalov]

Please see my comments.


REPOSITORY
  rL LLVM

================
Comment at: source/Host/posix/PipePosix.cpp:196
@@ +195,3 @@
+    llvm::SmallString<PATH_MAX> named_pipe_path;
+    llvm::SmallString<PATH_MAX> pipe_spec;
+    pipe_spec = prefix;
----------------
Is it possible to combine all 3 statements of pipe_spec initialization? I mean, sth like this - const llvm::SmallString<PATH_MAX> pipe_spec (prefix + ".%%%%%%") ;

================
Comment at: source/Host/posix/PipePosix.cpp:236
@@ -198,1 +235,3 @@
+    {
+        m_name = name;
         m_fds[READ] = fd;
----------------
For the sake of consistency, please set the name within PipePosix::OpenAsWriterWithTimeout as well - before m_fds[WRITE] = fd;

http://reviews.llvm.org/D7348

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/