[Lldb-commits] [PATCH] Fix break-insert command on Windows.

Zachary Turner zturner at google.com
Wed Feb 4 09:21:41 PST 2015


Ahh, no need, if that's the case it's fine. I'll look at the patch in a bit
(on mobile right now)
On Wed, Feb 4, 2015 at 9:19 AM Hafiz Abid Qadeer <abidh.haq at gmail.com>
wrote:

> On Linux, eclipse send the normal path like
> 37-break-insert -f /home/abidh/work/test.c:28
>
> I agree with that check about ePathSyntaxWindows. We dont want to put
> penalty on other platforms. But looking at Normalize function, it seems
> that std::replace only gets called when we have syntax ==
> ePathSyntaxWindows. It returns early for ePathSyntaxPosix. But I can put an
> explicit check if required.
>
>
> http://reviews.llvm.org/D7379
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150204/e4b0bfa5/attachment.html>


More information about the lldb-commits mailing list