[Lldb-commits] [PATCH] Fix break-insert command on Windows.

Hafiz Abid Qadeer abidh.haq at gmail.com
Wed Feb 4 09:19:07 PST 2015


On Linux, eclipse send the normal path like
37-break-insert -f /home/abidh/work/test.c:28

I agree with that check about ePathSyntaxWindows. We dont want to put penalty on other platforms. But looking at Normalize function, it seems that std::replace only gets called when we have syntax == ePathSyntaxWindows. It returns early for ePathSyntaxPosix. But I can put an explicit check if required.


http://reviews.llvm.org/D7379

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list