[Lldb-commits] [PATCH] Add -exec-arguments command

Jim Ingham jingham at apple.com
Wed Jan 21 11:09:19 PST 2015


My suggestion was to have the SBTarget vend the SBLaunchInfo it WOULD use if you were to call launch without providing an SBLaunchInfo of your own.  Unfortunately, the underlying target doesn't actually use a ProcessLaunch info to store these settings, it stores the individual bits.  That's purely historical: the ProcessLaunchInfo was a later invention, and was layered onto of the existing code without re-working it.   We should probably change that at some point.

So if you want extra credit it would be great to re-plumb this stuff.  But I can understand if that's way more than you thought you were biting off for this task.  I'm still unhappy about adding yet another way to set run arguments, and once it's in the SB API's we're stuck with it for a while.

But given that it's our fault we are in this situation, it doesn't seem fair to push this too hard.

Jim


http://reviews.llvm.org/D6965

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list