[Lldb-commits] [PATCH] Add -exec-arguments command

[jingham at apple.com]

My suggestion was to have the SBTarget vend the SBLaunchInfo it WOULD use if you were to call launch without providing an SBLaunchInfo of your own.  Unfortunately, the underlying target doesn't actually use a ProcessLaunch info to store these settings, it stores the individual bits.  That's purely historical: the ProcessLaunchInfo was a later invention, and was layered onto of the existing code without re-working it.   We should probably change that at some point.  

So if you want extra credit it would be great to re-plumb this stuff.  But I can understand if that's way more than you thought you were biting off for this task.  I'm still unhappy about adding yet another way to set run arguments, and once it's in the SB API's we're stuck with it for a while.

But given that it's our fault we are in this situation, it doesn't seem fair to push this too hard.

Jim


> On Jan 20, 2015, at 5:13 AM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> In http://reviews.llvm.org/D6965#110597, @jingham wrote:
> 
>> If we want to have a way to directly set the arguments in a Target, I would prefer to have the SBTarget vend the SBLaunchInfo that it will use when it launches (if you don't give it another SBLaunchInfo) and then set the arguments there.
> 
> 
> The "process launch" command uses lldb_private (i.e. not public lldb API) and it creates LaunchInfo every time it is executed. I can't affect to that LaunchInfo instance using the public API.
> 
>> Right now it is pretty incoherent, you can set arguments in the run-args, you can set them directly when you call launch, you can set them in a SBLaunchInfo which you pass to the target, and now you can set then by passing in an SBArgs.  That's too many ways to do the same thing.
> 
> 
> Maybe it's so but I don't want to create one more way of setting arguments in lldb_private::Target class. I just have made a wrapper for the existing method.
> 
> 
> http://reviews.llvm.org/D6965
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
>