[Lldb-commits] [PATCH] remote-gdb-server platform able to run processes on a remote system

Greg Clayton clayborg at gmail.com
Tue Jan 20 11:30:12 PST 2015


See inline command about checking "bytes_written" for zero. Fix that and it is good to go.


REPOSITORY
  rL LLVM

================
Comment at: source/Target/Platform.cpp:1274
@@ +1273,3 @@
+        {
+            const uint64_t bytes_written = WriteFile(dest_file, offset, buffer_sp->GetBytes(), bytes_read, error);
+            offset += bytes_written;
----------------
ovyalov wrote:
> ditto.
We need to check for "bytes_written" being zero and break out if it is zero otherwise we will spin for ever here.

http://reviews.llvm.org/D7049

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list