[Lldb-commits] [PATCH] remote-gdb-server platform able to run processes on a remote system
Oleksiy Vyalov
ovyalov at google.com
Tue Jan 20 11:19:23 PST 2015
REPOSITORY
rL LLVM
================
Comment at: source/Target/Platform.cpp:1272
@@ +1271,3 @@
+ error = source_file.Read(buffer_sp->GetBytes(), bytes_read);
+ if (bytes_read)
+ {
----------------
Do we need to check for error here?
================
Comment at: source/Target/Platform.cpp:1274
@@ +1273,3 @@
+ {
+ const uint64_t bytes_written = WriteFile(dest_file, offset, buffer_sp->GetBytes(), bytes_read, error);
+ offset += bytes_written;
----------------
ditto.
http://reviews.llvm.org/D7049
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list