[Lldb-commits] [PATCH] Extend PipePosix with support for named pipes/timeout-based IO and integrate it with GDBRemoteCommunication / lldb-gdbserver.

Oleksiy Vyalov ovyalov at google.com
Tue Jan 13 14:32:21 PST 2015


Please see my comment.


================
Comment at: include/lldb/Host/PipeBase.h:32
@@ -30,1 +31,3 @@
+    Error OpenAsWriter(llvm::StringRef name, bool child_process_inherit);
+    virtual Error OpenAsWriterWithTimeout(llvm::StringRef name, bool child_process_inherit, const std::chrono::microseconds &timeout) = 0;
 
----------------
zturner wrote:
> This probably needs to go away now too.
We need this method on POSIX systems since attempt to open a writer in non-blocking mode fails with ENXIO if corresponding reader side hasn't opened yet. So, timeout allows to wait for a reader to be opened.

http://reviews.llvm.org/D6954

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list