[Lldb-commits] [PATCH] Extend PipePosix with support for named pipes/timeout-based IO and integrate it with GDBRemoteCommunication / lldb-gdbserver.

[Zachary Turner]

Looks good, I like this better.  In the future if we need to write with timeout we can add a WriteWithTimeout().  But usually that's not a common operation since it's not often you have to serialize on writes, so I expect it won't be needed.

Feel free to submit after removing OpenAsWriterWithTimeout().


================
Comment at: include/lldb/Host/PipeBase.h:32
@@ -30,1 +31,3 @@
+    Error OpenAsWriter(llvm::StringRef name, bool child_process_inherit);
+    virtual Error OpenAsWriterWithTimeout(llvm::StringRef name, bool child_process_inherit, const std::chrono::microseconds &timeout) = 0;
 
----------------
This probably needs to go away now too.

http://reviews.llvm.org/D6954

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/