[Lldb-commits] [PATCH] SyntheticChildrenFrontEnd::* should also be built when python is disabled

[Enrico Granata]

LGTM

> On Dec 12, 2014, at 3:39 PM, Keno Fischer <kfischer at college.harvard.edu> wrote:
> 
> Hi granata.enrico,
> 
> This moves 
> - SyntheticChildrenFrontEnd::CreateValueObjectFromExpression
> - SyntheticChildrenFrontEnd::CreateValueObjectFromAddress
> - SyntheticChildrenFrontEnd::CreateValueObjectFromData
> outside the `#ifndef LLDB_DISABLE_PYTHON` since it doesn't seem to depend on python being available and indeed breaks the build when python is disabled.
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D6646
> 
> Files:
>  source/DataFormatters/TypeSynthetic.cpp
> 
> Index: source/DataFormatters/TypeSynthetic.cpp
> ===================================================================
> --- source/DataFormatters/TypeSynthetic.cpp
> +++ source/DataFormatters/TypeSynthetic.cpp
> @@ -63,6 +63,41 @@
>     return sstr.GetString();
> }
> 
> +lldb::ValueObjectSP
> +SyntheticChildrenFrontEnd::CreateValueObjectFromExpression (const char* name,
> +                                                            const char* expression,
> +                                                            const ExecutionContext& exe_ctx)
> +{
> +    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromExpression(name, expression, exe_ctx));
> +    if (valobj_sp)
> +        valobj_sp->SetSyntheticChildrenGenerated(true);
> +    return valobj_sp;
> +}
> +
> +lldb::ValueObjectSP
> +SyntheticChildrenFrontEnd::CreateValueObjectFromAddress (const char* name,
> +                                                         uint64_t address,
> +                                                         const ExecutionContext& exe_ctx,
> +                                                         ClangASTType type)
> +{
> +    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromAddress(name, address, exe_ctx, type));
> +    if (valobj_sp)
> +        valobj_sp->SetSyntheticChildrenGenerated(true);
> +    return valobj_sp;
> +}
> +
> +lldb::ValueObjectSP
> +SyntheticChildrenFrontEnd::CreateValueObjectFromData (const char* name,
> +                                                      const DataExtractor& data,
> +                                                      const ExecutionContext& exe_ctx,
> +                                                      ClangASTType type)
> +{
> +    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromData(name, data, exe_ctx, type));
> +    if (valobj_sp)
> +        valobj_sp->SetSyntheticChildrenGenerated(true);
> +    return valobj_sp;
> +}
> +
> #ifndef LLDB_DISABLE_PYTHON
> 
> ScriptedSyntheticChildren::FrontEnd::FrontEnd(std::string pclass, ValueObject &backend) :
> @@ -111,39 +146,4 @@
>     return sstr.GetString();
> }
> 
> -lldb::ValueObjectSP
> -SyntheticChildrenFrontEnd::CreateValueObjectFromExpression (const char* name,
> -                                                            const char* expression,
> -                                                            const ExecutionContext& exe_ctx)
> -{
> -    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromExpression(name, expression, exe_ctx));
> -    if (valobj_sp)
> -        valobj_sp->SetSyntheticChildrenGenerated(true);
> -    return valobj_sp;
> -}
> -
> -lldb::ValueObjectSP
> -SyntheticChildrenFrontEnd::CreateValueObjectFromAddress (const char* name,
> -                                                         uint64_t address,
> -                                                         const ExecutionContext& exe_ctx,
> -                                                         ClangASTType type)
> -{
> -    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromAddress(name, address, exe_ctx, type));
> -    if (valobj_sp)
> -        valobj_sp->SetSyntheticChildrenGenerated(true);
> -    return valobj_sp;
> -}
> -
> -lldb::ValueObjectSP
> -SyntheticChildrenFrontEnd::CreateValueObjectFromData (const char* name,
> -                                                      const DataExtractor& data,
> -                                                      const ExecutionContext& exe_ctx,
> -                                                      ClangASTType type)
> -{
> -    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromData(name, data, exe_ctx, type));
> -    if (valobj_sp)
> -        valobj_sp->SetSyntheticChildrenGenerated(true);
> -    return valobj_sp;
> -}
> -
> #endif // #ifndef LLDB_DISABLE_PYTHON
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D6646.17247.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141212/86817b28/attachment.html>