<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">LGTM<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 12, 2014, at 3:39 PM, Keno Fischer <<a href="mailto:kfischer@college.harvard.edu" class="">kfischer@college.harvard.edu</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi granata.enrico,<br class=""><br class="">This moves <br class="">- SyntheticChildrenFrontEnd::CreateValueObjectFromExpression<br class="">- SyntheticChildrenFrontEnd::CreateValueObjectFromAddress<br class="">- SyntheticChildrenFrontEnd::CreateValueObjectFromData<br class="">outside the `#ifndef LLDB_DISABLE_PYTHON` since it doesn't seem to depend on python being available and indeed breaks the build when python is disabled.<br class=""><br class="">REPOSITORY<br class="">  rL LLVM<br class=""><br class=""><a href="http://reviews.llvm.org/D6646" class="">http://reviews.llvm.org/D6646</a><br class=""><br class="">Files:<br class="">  source/DataFormatters/TypeSynthetic.cpp<br class=""><br class="">Index: source/DataFormatters/TypeSynthetic.cpp<br class="">===================================================================<br class="">--- source/DataFormatters/TypeSynthetic.cpp<br class="">+++ source/DataFormatters/TypeSynthetic.cpp<br class="">@@ -63,6 +63,41 @@<br class="">     return sstr.GetString();<br class=""> }<br class=""><br class="">+lldb::ValueObjectSP<br class="">+SyntheticChildrenFrontEnd::CreateValueObjectFromExpression (const char* name,<br class="">+                                                            const char* expression,<br class="">+                                                            const ExecutionContext& exe_ctx)<br class="">+{<br class="">+    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromExpression(name, expression, exe_ctx));<br class="">+    if (valobj_sp)<br class="">+        valobj_sp->SetSyntheticChildrenGenerated(true);<br class="">+    return valobj_sp;<br class="">+}<br class="">+<br class="">+lldb::ValueObjectSP<br class="">+SyntheticChildrenFrontEnd::CreateValueObjectFromAddress (const char* name,<br class="">+                                                         uint64_t address,<br class="">+                                                         const ExecutionContext& exe_ctx,<br class="">+                                                         ClangASTType type)<br class="">+{<br class="">+    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromAddress(name, address, exe_ctx, type));<br class="">+    if (valobj_sp)<br class="">+        valobj_sp->SetSyntheticChildrenGenerated(true);<br class="">+    return valobj_sp;<br class="">+}<br class="">+<br class="">+lldb::ValueObjectSP<br class="">+SyntheticChildrenFrontEnd::CreateValueObjectFromData (const char* name,<br class="">+                                                      const DataExtractor& data,<br class="">+                                                      const ExecutionContext& exe_ctx,<br class="">+                                                      ClangASTType type)<br class="">+{<br class="">+    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromData(name, data, exe_ctx, type));<br class="">+    if (valobj_sp)<br class="">+        valobj_sp->SetSyntheticChildrenGenerated(true);<br class="">+    return valobj_sp;<br class="">+}<br class="">+<br class=""> #ifndef LLDB_DISABLE_PYTHON<br class=""><br class=""> ScriptedSyntheticChildren::FrontEnd::FrontEnd(std::string pclass, ValueObject &backend) :<br class="">@@ -111,39 +146,4 @@<br class="">     return sstr.GetString();<br class=""> }<br class=""><br class="">-lldb::ValueObjectSP<br class="">-SyntheticChildrenFrontEnd::CreateValueObjectFromExpression (const char* name,<br class="">-                                                            const char* expression,<br class="">-                                                            const ExecutionContext& exe_ctx)<br class="">-{<br class="">-    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromExpression(name, expression, exe_ctx));<br class="">-    if (valobj_sp)<br class="">-        valobj_sp->SetSyntheticChildrenGenerated(true);<br class="">-    return valobj_sp;<br class="">-}<br class="">-<br class="">-lldb::ValueObjectSP<br class="">-SyntheticChildrenFrontEnd::CreateValueObjectFromAddress (const char* name,<br class="">-                                                         uint64_t address,<br class="">-                                                         const ExecutionContext& exe_ctx,<br class="">-                                                         ClangASTType type)<br class="">-{<br class="">-    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromAddress(name, address, exe_ctx, type));<br class="">-    if (valobj_sp)<br class="">-        valobj_sp->SetSyntheticChildrenGenerated(true);<br class="">-    return valobj_sp;<br class="">-}<br class="">-<br class="">-lldb::ValueObjectSP<br class="">-SyntheticChildrenFrontEnd::CreateValueObjectFromData (const char* name,<br class="">-                                                      const DataExtractor& data,<br class="">-                                                      const ExecutionContext& exe_ctx,<br class="">-                                                      ClangASTType type)<br class="">-{<br class="">-    ValueObjectSP valobj_sp(ValueObject::CreateValueObjectFromData(name, data, exe_ctx, type));<br class="">-    if (valobj_sp)<br class="">-        valobj_sp->SetSyntheticChildrenGenerated(true);<br class="">-    return valobj_sp;<br class="">-}<br class="">-<br class=""> #endif // #ifndef LLDB_DISABLE_PYTHON<br class=""><br class="">EMAIL PREFERENCES<br class="">  http://reviews.llvm.org/settings/panel/emailpreferences/<br class=""><span id="cid:888826AC-B1E6-4DA1-A17A-363482C0AF74@apple.com"><D6646.17247.patch></span>_______________________________________________<br class="">lldb-commits mailing list<br class="">lldb-commits@cs.uiuc.edu<br class="">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits<br class=""></div></blockquote></div><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Thanks,</div><div class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div><div class=""><br class=""></div></div></div></div></div></div><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<br class=""></div></body></html>