[Lldb-commits] [PATCH] Fix some posixy assumptions that were used during RunShellCommand

Greg Clayton clayborg at gmail.com
Fri Dec 5 15:30:04 PST 2014

Seems like we should either get this from a call like the one that gets "cmd.exe" (HostInfoWindows::GetDefaultShell()). In Host::RunShellCommand() we already do:



We should be asking the HostInfo class to be setting the shell arguments for us. Then we HostInfoPosix and HostInfoWindows could "do the right thing".

So I vote to remove ProcessLaunchInfo::ConvertArgumentsForLaunchingInShell(), then create a function in the HostInfo class that can do this correctly for each system. This function is only used in Platform::LaunchProcess() when "IsHost()" is true and in Host::RunShellCommand().


More information about the lldb-commits mailing list