[Lldb-commits] [PATCH] Fix some posixy assumptions that were used during RunShellCommand

[Zachary Turner]

In ConvertArgumentsForLaunchingInShell(), do you suggest I change the
conditional to use /C if the shell name is "cmd.exe"?  Seems a little
hackish, so if there's a better way then that would be preferable.

What about setting the Architecture as I'm currently doing, but modify the
triple so it only contains OS and Environment, but not architecture?

On Fri Dec 05 2014 at 2:57:10 PM Greg Clayton <clayborg at gmail.com> wrote:

> The architecture check is in case you have a universal file that contains
> both x86_64 and i386, you might set the architecture to specify you want to
> run (debug more like it) the i386 slice even though you are on a 64 bit
> system (MacOSX supports this). For running a shell command, just let the
> system do what it needs to do and launch it using the best slice it can and
> don't set the architecture in the launch info.
>
> So please remove "launch_info.SetArchitecture(HostInfo::GetArchitecture());"
> from Host::RunShellCommand().
>
> http://reviews.llvm.org/D6553
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141205/5822ad7f/attachment.html>