[Lldb-commits] [PATCH] fix lldb-mi hang on OSX

[Zachary Turner]

On Tue Dec 02 2014 at 10:13:01 AM <dawn at burble.org> wrote:

> On Tue, Dec 02, 2014 at 05:45:21PM +0000, Abid, Hafiz wrote:
>
> > >Side comment, But regarding conditionally compiling the file, i prefer
> doing that at the CMake level (only include it in the set of inputs if the
> platform is correct) instead of wrapping the whole file in ifdefs.
> > Agree. But if problem is handled at the build level then autoconf based
> system should be updated too. Anyway, this issue can be dealt separately.
>
> For those of us that have no clue on how to work with XCode projects,
> tweaking just the cmake and gnu makefiles can break those builds.  Lldb-mi
> wasn't being built in XCode last I checked, but I expect it will be some
> say.
>

I think people are generally OK with this.  If it's going to end up
requiring a major effort to fix up on another platform, it's a good idea to
coordinate the efforts with them ahead of time.  But for something trivial
like this where they will probably just have to make a minor tweak to their
project settings, people are ok with doing that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141202/e517ac45/attachment.html>