[Lldb-commits] [PATCH] fix lldb-mi hang on OSX
dawn at burble.org
dawn at burble.org
Tue Dec 2 10:12:59 PST 2014
On Tue, Dec 02, 2014 at 05:45:21PM +0000, Abid, Hafiz wrote:
> I see only one fileno call inside lldb-mi and that is specific to Windows code. Probably some fileno call inside lldb proper is causing this issue. In which case, there is nothing much lldb-mi can do but to try to avoid this scenario. As I told earlier, ???select??? based solution increases time to run test many times. So that does not seem reasonable. I am OK with ioctl based solution and will commit it later if there are no more comments/suggestion.
Thank you for checking which solution is better for Linux. Looking forward to
the ioctl commit then :). Perhaps you could add some of this discussion to the
comment in CMICmnStreamStdinLinux::InputAvailable for posterity?
> >Side comment, But regarding conditionally compiling the file, i prefer doing that at the CMake level (only include it in the set of inputs if the platform is correct) instead of wrapping the whole file in ifdefs.
> Agree. But if problem is handled at the build level then autoconf based system should be updated too. Anyway, this issue can be dealt separately.
For those of us that have no clue on how to work with XCode projects,
tweaking just the cmake and gnu makefiles can break those builds. Lldb-mi
wasn't being built in XCode last I checked, but I expect it will be some say.
> [...] What do you think of
> creating a derived class of ' CMICmnStreamStdinLinux' for OSX and
> overriding InputAvailable in it.
As for this part, I agree it is a bit of a mess right now, but as Ilia points
out, it is not as simple as it sounds. We should at least rename the classes
and files though. Ok to replace Linux with POSIX in the files and classes?
More information about the lldb-commits