[Lldb-commits] [PATCH] Change the way SWIG is found, and fixed a typo in OS detection

[Zachary Turner]

I would just leave it out until we have an actual need for it.  No reason
to add complexity (however small) that nobody needs.

On Mon Nov 17 2014 at 9:57:53 AM Ed Maste <emaste at freebsd.org> wrote:

> ================
> Comment at: scripts/CMakeLists.txt:12
> @@ -12,1 +11,3 @@
> +         DEPENDS ${SWIG_INPUTS}
> +         COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/buildSwigWrapperClasses.py
> "--srcRoot=${LLDB_SOURCE_DIR}" "--targetDir=${CMAKE_CURRENT_BINARY_DIR}"
> "--cfgBldDir=${CMAKE_CURRENT_BINARY_DIR}" "--prefix=${CMAKE_BINARY_DIR}"
> "--swigDir=${SWIG_DIR}" "--swigExecutable=${SWIG_EXECUTABLE}" -m
>           COMMENT "Python script building LLDB Python wrapper")
> ----------------
> ismailp wrote:
> > emaste wrote:
> > > I must be missing something -- I don't see how swigDir is used.
> > CMake is setting that variable. That directory seems like to include
> skeleton/template/boilerplate files. buildSwigWrapperClasses.py, however,
> doesn't use it. I thought it might be useful in the future, and kept it.
> Perhaps it's best to remove it to prevent confusion.
> Yeah, if there are no consumers yet I would leave it out for now. Or, add
> a comment that it's not yet used but will be soon if that's the case.
>
> http://reviews.llvm.org/D6290
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141117/bb882761/attachment.html>