[Lldb-commits] [PATCH] Change the way SWIG is found, and fixed a typo in OS detection

Ed Maste emaste at freebsd.org
Mon Nov 17 09:57:49 PST 2014

Comment at: scripts/CMakeLists.txt:12
@@ -12,1 +11,3 @@
+	  COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/buildSwigWrapperClasses.py "--srcRoot=${LLDB_SOURCE_DIR}" "--targetDir=${CMAKE_CURRENT_BINARY_DIR}" "--cfgBldDir=${CMAKE_CURRENT_BINARY_DIR}" "--prefix=${CMAKE_BINARY_DIR}" "--swigDir=${SWIG_DIR}" "--swigExecutable=${SWIG_EXECUTABLE}" -m
 	  COMMENT "Python script building LLDB Python wrapper")  
ismailp wrote:
> emaste wrote:
> > I must be missing something -- I don't see how swigDir is used.
> CMake is setting that variable. That directory seems like to include skeleton/template/boilerplate files. buildSwigWrapperClasses.py, however, doesn't use it. I thought it might be useful in the future, and kept it. Perhaps it's best to remove it to prevent confusion.
Yeah, if there are no consumers yet I would leave it out for now. Or, add a comment that it's not yet used but will be soon if that's the case.


More information about the lldb-commits mailing list