[Lldb-commits] [PATCH] Introduce a ProcessStatus monitor abstraction.

[Zachary Turner]

Gah, thanks for noticing the lldb-forward.h problem.  It's clang-format
doing that, it's not smart enough to align variables in cases where you've
chosen to not use standard 1-space separation between type and variable
names.

On Thu Oct 30 2014 at 1:21:24 PM Greg Clayton <clayborg at gmail.com> wrote:

> In include/lldb/Host/MonitoringProcessLauncher.h: please include
> lldb-forward.h and don't forward declare anything manually
>
> In explicit MonitoringProcessLauncher(lldb::ProcessStatusMonitorSP
> monitor, lldb::ProcessLauncherUP delegate_launcher); I would change each
> arg to be a const reference to avoid copies and reference counts being
> bumped.
>
> Change ProcessStatusMonitorCallbackEntry to not use std::pair and declare
> a small structure instead. Seeing "a.first" and "a.second" really doesn't
> help the readability of the code, so please make a struct with good member
> names ("callback" and "baton").
>
> In lldb-forward.h the spacing of the new stuff you added seems to be using
> tabs as it isn't indented the same as the others. Please make sure to use
> spaces instead of tabs.
>
> http://reviews.llvm.org/D6036
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141030/08d63af5/attachment.html>