[Lldb-commits] [PATCH] Introduce a ProcessStatus monitor abstraction.

Greg Clayton clayborg at gmail.com
Thu Oct 30 13:21:21 PDT 2014

In include/lldb/Host/MonitoringProcessLauncher.h: please include lldb-forward.h and don't forward declare anything manually

In explicit MonitoringProcessLauncher(lldb::ProcessStatusMonitorSP monitor, lldb::ProcessLauncherUP delegate_launcher); I would change each arg to be a const reference to avoid copies and reference counts being bumped.

Change ProcessStatusMonitorCallbackEntry to not use std::pair and declare a small structure instead. Seeing "a.first" and "a.second" really doesn't help the readability of the code, so please make a struct with good member names ("callback" and "baton").

In lldb-forward.h the spacing of the new stuff you added seems to be using tabs as it isn't indented the same as the others. Please make sure to use spaces instead of tabs.


More information about the lldb-commits mailing list