[Lldb-commits] [lldb] r219982 - The number '5' triggers a bug unrelated to LLDB, and is not instrumental to this test in any way. Use another, randomly chosen, number to make the test pass again and provide useful actionable feedback about things that truly matter

[Enrico Granata]

Author: enrico
Date: Thu Oct 16 18:06:40 2014
New Revision: 219982

URL: http://llvm.org/viewvc/llvm-project?rev=219982&view=rev
Log:
The number '5' triggers a bug unrelated to LLDB, and is not instrumental to this test in any way. Use another, randomly chosen, number to make the test pass again and provide useful actionable feedback about things that truly matter

Modified:
    lldb/trunk/test/expression_command/po_verbosity/TestPoVerbosity.py
    lldb/trunk/test/expression_command/po_verbosity/main.m

Modified: lldb/trunk/test/expression_command/po_verbosity/TestPoVerbosity.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/po_verbosity/TestPoVerbosity.py?rev=219982&r1=219981&r2=219982&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/po_verbosity/TestPoVerbosity.py (original)
+++ lldb/trunk/test/expression_command/po_verbosity/TestPoVerbosity.py Thu Oct 16 18:06:40 2014
@@ -20,7 +20,6 @@ class PoVerbosityTestCase(TestBase):
 
     @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
     @dsym_test
-    @expectedFailureDarwin(16374063)
     def test_with_dsym(self):
         """Test that the po command acts correctly."""
         self.buildDsym()
@@ -28,7 +27,6 @@ class PoVerbosityTestCase(TestBase):
 
     @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin due to ObjC test case")
     @dwarf_test
-    @expectedFailureDarwin(16374063)
     def test_with_dwarf(self):
         """Test that the po command acts correctly."""
         self.buildDwarf()
@@ -59,16 +57,16 @@ class PoVerbosityTestCase(TestBase):
         self.expect("expr -O -- foo",matching=False,
             substrs = ['(id) $'])
 
-        self.expect("expr -O -- 5",matching=False,
+        self.expect("expr -O -- 22",matching=False,
             substrs = ['(int) $'])
-        self.expect("expr -O -- 5",
-            substrs = ['5'])
+        self.expect("expr -O -- 22",
+            substrs = ['22'])
 
-        self.expect("expr -O -vfull -- 5",
-            substrs = ['(int) $', ' = 5'])
+        self.expect("expr -O -vfull -- 22",
+            substrs = ['(int) $', ' = 22'])
 
-        self.expect("expr -O -v -- 5",
-            substrs = ['(int) $', ' = 5'])
+        self.expect("expr -O -v -- 22",
+            substrs = ['(int) $', ' = 22'])
 
 
 if __name__ == '__main__':

Modified: lldb/trunk/test/expression_command/po_verbosity/main.m
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/po_verbosity/main.m?rev=219982&r1=219981&r2=219982&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/po_verbosity/main.m (original)
+++ lldb/trunk/test/expression_command/po_verbosity/main.m Thu Oct 16 18:06:40 2014
@@ -2,6 +2,7 @@
 
 int main()
 {
+    [NSString initialize];
 	id foo = @{@1 : @2, @2 : @3};
 	int x = 34;
 	return 0; // Stop here