[Lldb-commits] [lldb] r219689 - Fix dotest.py test runner exit code to return non-zero on failure/error.

Todd Fiala todd.fiala at gmail.com
Tue Oct 14 09:17:02 PDT 2014


Author: tfiala
Date: Tue Oct 14 11:17:02 2014
New Revision: 219689

URL: http://llvm.org/viewvc/llvm-project?rev=219689&view=rev
Log:
Fix dotest.py test runner exit code to return non-zero on failure/error.

This addresses this bug:
http://www.llvm.org/bugs/show_bug.cgi?id=21267

Which has been broken since svn r215256 on Aug 8 2014.

DO NOT REVERT THIS COMMIT EVEN IF IT CREATES TEST FAILURES.

The test failures are a result of accumulation of hidden failures
that were masked by the bug this change fixes.  Most of our test
runners as part of build testing rely on dotest.py returning non-zero to indicate
some kind of errant test run.  Thus, we have been flying blind
since Aug 8 2014.

Modified:
    lldb/trunk/test/dotest.py

Modified: lldb/trunk/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dotest.py?rev=219689&r1=219688&r2=219689&view=diff
==============================================================================
--- lldb/trunk/test/dotest.py (original)
+++ lldb/trunk/test/dotest.py Tue Oct 14 11:17:02 2014
@@ -1737,4 +1737,4 @@ if ("LLDB_TESTSUITE_FORCE_FINISH" in os.
     subprocess.Popen(["/bin/sh", "-c", "kill %s; exit 0" % (os.getpid())])
 
 # Exiting.
-exitTestSuite()
\ No newline at end of file
+exitTestSuite(failed)
\ No newline at end of file





More information about the lldb-commits mailing list