[Lldb-commits] [PATCH] Add a couple more paths where to look for just-build Clang

[Zachary Turner]

That seems reasonable.  I'm not sure how to do this with the Xcode build,
but with the CMake build perhaps you could add a new CMake variable called
LLDB_ENABLE_ASAN_TESTS.  This would append -fsanitize=address to the
command line args for the compiler, and also pass in a flag to the test
script so that it knows that @requiresAsanCompiler is true.

On Mon, Oct 13, 2014 at 10:27 AM, Kuba Brecka <kuba.brecka at gmail.com> wrote:

> You're right, that's probably a better approach. However, on OS X, it's
> quite possible your default compiler will not understand
> -fsanitize=address, and running just "./dotest.py" will have the ASan tests
> fail. I think we should have a @requiresAsanCompiler annotation that would
> detect and skip the test, if your compiler (either the default one or the
> one you set via LLDB_TEST_COMPILER) doesn't have ASan.
>
> Kuba
>
> Sent from my iPhone
>
> On Oct 13, 2014, at 9:52 AM, Zachary Turner <zturner at google.com> wrote:
>
> Are you using the CMake build?  Even this will fail if you have multiple
> clangs and you want it to choose a specific one.  I would suggest setting
> the LLDB_TEST_COMPILER CMake variable.
>
> On Fri, Oct 10, 2014 at 8:19 PM, Kuba Brecka <kuba.brecka at gmail.com>
> wrote:
>
>> Some LLDB build scripts seem to put the built Clang into different paths,
>> let's add a couple more paths where to look for Clang. Currently used only
>> by LLDB's ASan tests.
>>
>> http://reviews.llvm.org/D5740
>>
>> Files:
>>   test/lldbtest.py
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141013/d1dd61e0/attachment.html>