[Lldb-commits] lldb-gdbserver.cpp does not compile

Todd Fiala tfiala at google.com
Sat Sep 20 10:45:44 PDT 2014


Fix up here:

svn commit
Sending        tools/lldb-gdbserver/lldb-gdbserver.cpp
Transmitting file data .
Committed revision 218186.

I also snuck in a couple changes for places where I was passing by value
when I should have been passing by const ref.

On Sat, Sep 20, 2014 at 10:24 AM, Todd Fiala <tfiala at google.com> wrote:

> Thanks, looking into this now.
>
> On Sat, Sep 20, 2014 at 8:15 AM, Paul Osmialowski <newchief at king.net.pl>
> wrote:
>
>> Guys,
>>
>> After recent changes, lldb-gdbserver.cpp does not compile. Simple change
>> solves the problem:
>>
>> diff --git a/tools/lldb-gdbserver/lldb-gdbserver.cpp
>> b/tools/lldb-gdbserver/lldb-gdbserver.cpp
>> index 368f862..7a08102 100644
>> --- a/tools/lldb-gdbserver/lldb-gdbserver.cpp
>> +++ b/tools/lldb-gdbserver/lldb-gdbserver.cpp
>> @@ -180,7 +180,7 @@ setup_platform (const std::string platform_name)
>>      }
>>
>>      Error error;
>> -    platform_sp = Platform::Create (platform_name.c_str(), error);
>> +    platform_sp = Platform::Create (lldb_private::ConstString(platform_name),
>> error);
>>      if (error.Fail ())
>>      {
>>          // the host platform isn't registered with that name (at
>>
>>
>>
>>
>> Best regards,
>> Paul
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>
>
>
>
> --
> Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140920/c84d9728/attachment.html>


More information about the lldb-commits mailing list