<div dir="ltr">Fix up here:<div><br></div><div><div>svn commit</div><div>Sending tools/lldb-gdbserver/lldb-gdbserver.cpp</div><div>Transmitting file data .</div><div>Committed revision 218186.</div></div><div><br></div><div>I also snuck in a couple changes for places where I was passing by value when I should have been passing by const ref.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 20, 2014 at 10:24 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks, looking into this now.</div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Sat, Sep 20, 2014 at 8:15 AM, Paul Osmialowski <span dir="ltr"><<a href="mailto:newchief@king.net.pl" target="_blank">newchief@king.net.pl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Guys,<br>
<br>
After recent changes, lldb-gdbserver.cpp does not compile. Simple change solves the problem:<br>
<br>
diff --git a/tools/lldb-gdbserver/lldb-<u></u>gdbserver.cpp b/tools/lldb-gdbserver/lldb-<u></u>gdbserver.cpp<br>
index 368f862..7a08102 100644<br>
--- a/tools/lldb-gdbserver/lldb-<u></u>gdbserver.cpp<br>
+++ b/tools/lldb-gdbserver/lldb-<u></u>gdbserver.cpp<br>
@@ -180,7 +180,7 @@ setup_platform (const std::string platform_name)<br>
}<br>
<br>
Error error;<br>
- platform_sp = Platform::Create (platform_name.c_str(), error);<br>
+ platform_sp = Platform::Create (lldb_private::ConstString(<u></u>platform_name), error);<br>
if (error.Fail ())<br>
{<br>
// the host platform isn't registered with that name (at<br>
<br>
<br>
<br>
<br>
Best regards,<br>
Paul<br>
<br>
______________________________<u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>