[Lldb-commits] [PATCH] [lldb] Rename ThreadList to ProcessThreadList and abstract a superclass for a generic thread container

[Kuba Brecka]

I see, that makes sense.

Kuba



On Fri, Sep 5, 2014 at 9:59 AM, <jingham at apple.com> wrote:

> I'd keep ThreadList as ThreadList, and make your new class
> ThreadCollection.
>
> Jim
>
> > On Sep 5, 2014, at 9:50 AM, Kuba Brecka <kuba.brecka at gmail.com> wrote:
> >
> > So just the base class should be "ThreadCollection"? Or even the
> ProcessThreadList should be renamed?
> >
> > Kuba
> >
> >
> >
> > On Fri, Sep 5, 2014 at 9:13 AM, <jingham at apple.com> wrote:
> > In the case of breakpoint locations, I use "List" to mean a collection
> of things with other constraints - i.e. all belonging to the same
> breakpoint in the BreakpointLocation case, and "Collection" to mean a
> container of a bunch of stuff.  If it's not too much bother, it might be
> nice to keep using that convention?
> >
> > Jim
> >
> > > On Sep 4, 2014, at 7:08 PM, Kuba Brecka <kuba.brecka at gmail.com> wrote:
> > >
> > > Based on the conversation at
> http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140901/012760.html
> this patch splits the current ThreadList class into a process-related
> thread object called "ProcessThreadList" and a generic thread list now
> called just ThreadList. The idea is to expose the ThreadList as
> SBThreadList and make ASan-related API based on it.
> > >
> > > http://reviews.llvm.org/D5200
> > >
> > > Files:
> > >  include/lldb/Target/OperatingSystem.h
> > >  include/lldb/Target/Process.h
> > >  include/lldb/Target/ProcessThreadList.h
> > >  include/lldb/Target/Thread.h
> > >  include/lldb/Target/ThreadList.h
> > >  include/lldb/lldb-forward.h
> > >  lldb.xcodeproj/project.pbxproj
> > >  source/Commands/CommandObjectTarget.cpp
> > >  source/Core/Debugger.cpp
> > >  source/Core/IOHandler.cpp
> > >  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
> > >  source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
> > >  source/Plugins/OperatingSystem/Python/OperatingSystemPython.h
> > >  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
> > >  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h
> > >  source/Plugins/Process/elf-core/ProcessElfCore.cpp
> > >  source/Plugins/Process/elf-core/ProcessElfCore.h
> > >  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
> > >  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
> > >  source/Plugins/Process/mach-core/ProcessMachCore.cpp
> > >  source/Plugins/Process/mach-core/ProcessMachCore.h
> > >  source/Target/Process.cpp
> > >  source/Target/ProcessThreadList.cpp
> > >  source/Target/Target.cpp
> > >  source/Target/ThreadList.cpp
> > > <D5200.13297.patch>_______________________________________________
> > > lldb-commits mailing list
> > > lldb-commits at cs.uiuc.edu
> > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140905/fab63c16/attachment.html>