<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">I see, that makes sense.</span><br><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Kuba</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 5, 2014 at 9:59 AM,  <span dir="ltr"><<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'd keep ThreadList as ThreadList, and make your new class ThreadCollection.<br>
<br>
Jim<br>
<div class="HOEnZb"><div class="h5"><br>
> On Sep 5, 2014, at 9:50 AM, Kuba Brecka <<a href="mailto:kuba.brecka@gmail.com">kuba.brecka@gmail.com</a>> wrote:<br>
><br>
> So just the base class should be "ThreadCollection"? Or even the ProcessThreadList should be renamed?<br>
><br>
> Kuba<br>
><br>
><br>
><br>
> On Fri, Sep 5, 2014 at 9:13 AM, <<a href="mailto:jingham@apple.com">jingham@apple.com</a>> wrote:<br>
> In the case of breakpoint locations, I use "List" to mean a collection of things with other constraints - i.e. all belonging to the same breakpoint in the BreakpointLocation case, and "Collection" to mean a container of a bunch of stuff.  If it's not too much bother, it might be nice to keep using that convention?<br>
><br>
> Jim<br>
><br>
> > On Sep 4, 2014, at 7:08 PM, Kuba Brecka <<a href="mailto:kuba.brecka@gmail.com">kuba.brecka@gmail.com</a>> wrote:<br>
> ><br>
> > Based on the conversation at <a href="http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140901/012760.html" target="_blank">http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140901/012760.html</a> this patch splits the current ThreadList class into a process-related thread object called "ProcessThreadList" and a generic thread list now called just ThreadList. The idea is to expose the ThreadList as SBThreadList and make ASan-related API based on it.<br>
> ><br>
> > <a href="http://reviews.llvm.org/D5200" target="_blank">http://reviews.llvm.org/D5200</a><br>
> ><br>
> > Files:<br>
> >  include/lldb/Target/OperatingSystem.h<br>
> >  include/lldb/Target/Process.h<br>
> >  include/lldb/Target/ProcessThreadList.h<br>
> >  include/lldb/Target/Thread.h<br>
> >  include/lldb/Target/ThreadList.h<br>
> >  include/lldb/lldb-forward.h<br>
> >  lldb.xcodeproj/project.pbxproj<br>
> >  source/Commands/CommandObjectTarget.cpp<br>
> >  source/Core/Debugger.cpp<br>
> >  source/Core/IOHandler.cpp<br>
> >  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp<br>
> >  source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp<br>
> >  source/Plugins/OperatingSystem/Python/OperatingSystemPython.h<br>
> >  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
> >  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h<br>
> >  source/Plugins/Process/elf-core/ProcessElfCore.cpp<br>
> >  source/Plugins/Process/elf-core/ProcessElfCore.h<br>
> >  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp<br>
> >  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h<br>
> >  source/Plugins/Process/mach-core/ProcessMachCore.cpp<br>
> >  source/Plugins/Process/mach-core/ProcessMachCore.h<br>
> >  source/Target/Process.cpp<br>
> >  source/Target/ProcessThreadList.cpp<br>
> >  source/Target/Target.cpp<br>
> >  source/Target/ThreadList.cpp<br>
> > <D5200.13297.patch>_______________________________________________<br>
> > lldb-commits mailing list<br>
> > <a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div>