[Lldb-commits] [PATCH] Fix Linux lldb local and remote debugging to respect the flag to disable ASLR.

[Todd Fiala]

The defined flags were meant to prevent issues we've hit when
cross-compiling for ARM simulators where the cross-compilers occasionally
are missing some values. But I didn't actually hit that so fair enough, I
can remove it until we know it's an issue.

I just need a buddy build on FreeBSD (or I can watch their buildbot).

On Saturday, August 16, 2014, Chandler Carruth <chandlerc at gmail.com> wrote:

> Looks good to me.
>
> ================
> Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:96-98
> @@ -94,2 +95,5 @@
>
> +// Define personality-related custom flag here so cross compilers and
> others always have the flag.
> +#define LLDB_PERSONALITY_ADDR_NO_RANDOMIZE     0x00040000
> +#define LLDB_PERSONALITY_GET_CURRENT_SETTINGS  0xffffffff
>
> ----------------
> The comment here doesn't make much sense in a file which unconditionally
> #includes <linux/unistd.h> and <sys/personality.h>. This file can only be
> compiled on a Linux host or with a Linux SDK kicking around.
>
> I think you can just use the enums from <sys/personality.h>. They aren't
> weird or surprising even if their documentation is limited.
>
> http://reviews.llvm.org/D4941
>
>
>

-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140816/357453d1/attachment.html>