[Lldb-commits] [PATCH] Fix Linux lldb local and remote debugging to respect the flag to disable ASLR.

[Chandler Carruth]

Looks good to me.

================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:96-98
@@ -94,2 +95,5 @@
 
+// Define personality-related custom flag here so cross compilers and others always have the flag.
+#define LLDB_PERSONALITY_ADDR_NO_RANDOMIZE     0x00040000
+#define LLDB_PERSONALITY_GET_CURRENT_SETTINGS  0xffffffff
 
----------------
The comment here doesn't make much sense in a file which unconditionally #includes <linux/unistd.h> and <sys/personality.h>. This file can only be compiled on a Linux host or with a Linux SDK kicking around.

I think you can just use the enums from <sys/personality.h>. They aren't weird or surprising even if their documentation is limited.

http://reviews.llvm.org/D4941