[Lldb-commits] [lldb] r215223 - Add new MI commands, features and fixes to the lldb-mi driver.

[Deepak Panickal]

Yeah, I understand. 

The lldb-mi driver is a sub project which only we have been committing to and working on primarily. It’s separate from the core files of LLDB. Which is why I committed a bigger patch.

I agree with you that smaller incremental patches are always better, and would try to stick to that as much as possible.

On 8 Aug 2014, at 19:25, Chandler Carruth <chandlerc at google.com> wrote:

> 
> On Fri, Aug 8, 2014 at 9:47 AM, Deepak Panickal <deepak at codeplay.com> wrote:
> Author: panickal
> Date: Fri Aug  8 11:47:42 2014
> New Revision: 215223
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=215223&view=rev
> Log:
> Add new MI commands, features and fixes to the lldb-mi driver.
> 
> - Can now load an executable directly as an argument.
> - Fixes towards supporting local debugging.
> - Fixes for stack-list-arguments, data-evaluate-expression, environment-cd, stack-list-locals, interpreter-exec.
> - Fix breakpoint event handling.
> - Support dynamic loading of libraries using the search paths provided by Eclipse.
> 
> I realize that LLDB as a project hasn't been enforcing this for a long time, but the practice of code-dropping such huge patches with so many changes merged together is pretty directly against the LLVM developer policy which LLDB still needs to abide by:
> 
> http://llvm.org/docs/DeveloperPolicy.html#incremental-development
> 
> This causes lots of problems not the least among them lost changes, you even had to fix some after this submit. It also makes code review completely impossible.
> 
> Please work to switch to a development style compatible with the LLVM process, preferably with small and incremental patches that can be easily code reviewed.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140809/90f31b2a/attachment.html>