<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Yeah, I understand. <div><br></div><div>The lldb-mi driver is a sub project which only we have been committing to and working on primarily. It’s separate from the core files of LLDB. Which is why I committed a bigger patch.</div><div><br></div><div><div>I agree with you that smaller incremental patches are always better, and would try to stick to that as much as possible.</div><div><br><div><div>On 8 Aug 2014, at 19:25, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 8, 2014 at 9:47 AM, Deepak Panickal <span dir="ltr"><<a href="mailto:deepak@codeplay.com" target="_blank">deepak@codeplay.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div id=":81c" class="" style="overflow:hidden">Author: panickal<br>
Date: Fri Aug 8 11:47:42 2014<br>
New Revision: 215223<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=215223&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=215223&view=rev</a><br>
Log:<br>
Add new MI commands, features and fixes to the lldb-mi driver.<br>
<br>
- Can now load an executable directly as an argument.<br>
- Fixes towards supporting local debugging.<br>
- Fixes for stack-list-arguments, data-evaluate-expression, environment-cd, stack-list-locals, interpreter-exec.<br>
- Fix breakpoint event handling.<br>
- Support dynamic loading of libraries using the search paths provided by Eclipse.</div></blockquote></div><br>I realize that LLDB as a project hasn't been enforcing this for a long time, but the practice of code-dropping such huge patches with so many changes merged together is pretty directly against the LLVM developer policy which LLDB still needs to abide by:</div>
<div class="gmail_extra"><br></div><div class="gmail_extra"><a href="http://llvm.org/docs/DeveloperPolicy.html#incremental-development">http://llvm.org/docs/DeveloperPolicy.html#incremental-development</a><br></div><div class="gmail_extra">
<br></div><div class="gmail_extra">This causes lots of problems not the least among them lost changes, you even had to fix some after this submit. It also makes code review completely impossible.</div><div class="gmail_extra">
<br></div><div class="gmail_extra">Please work to switch to a development style compatible with the LLVM process, preferably with small and incremental patches that can be easily code reviewed.</div></div>
</blockquote></div><br></div></div></body></html>