[Lldb-commits] [PATCH] Add kalimba architecture checking to TestImageListMultiArchitecture

[Todd Fiala]

I'll have a look at this now.  If I can run the test successfully, I'll get
it in.

Thanks for zipping the object code, I'm sure that'll make this easier :-)


On Wed, Jul 23, 2014 at 4:50 AM, Matthew Gardiner <mg11 at csr.com> wrote:

> Hi folks,
>
> Since I have recently added CSR's kalimba as an architecture to lldb, we
> thought it would be wise to enhance TestImageListMultiArchitecture to check
> that kalimba ELFs are identified correctly to avoid any regression.
>
> I'm uploading a patch to add this test functionality.
>
> In addition to modifying the .py file, I'm adding a .c file since the
> kalimba compiler (kcc) does not support C++. Additionally I'm attaching a
> gzipped ELF since I'm not convinced that "svn di" is capable of building my
> added binary into the patch file.
>
> Could someone please submit my patch if it seems ok?
>
> thanks Matt
>
> Index: test/functionalities/object-file/TestImageListMultiArchitecture.py
> ===================================================================
> --- test/functionalities/object-file/TestImageListMultiArchitecture.py
> (revision 213650)
> +++ test/functionalities/object-file/TestImageListMultiArchitecture.py
> (working copy)
> @@ -27,6 +27,7 @@
>              "hello-netbsd-6.1-x86_64-gcc-4.5.3":
> re.compile(r"x86_64-(unknown)?-netbsd x86_64"),
>              "hello-ubuntu-14.04-x86_64-gcc-4.8.2":
> re.compile(r"x86_64-(unknown)?-linux x86_64"),
>              "hello-ubuntu-14.04-x86_64-clang-3.5pre":
> re.compile(r"x86_64-(unknown)?-linux x86_64"),
> +            "hello-unknown-kalimba_arch4-kcc-36":
> re.compile(r"kalimba-csr-unknown kalimba"),
>          }
>
>          for image_name in images:
> Index: test/functionalities/object-file/bin/hello-unknown-
> kalimba_arch4-kcc-36
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/x-executable
> Index: test/functionalities/object-file/bin/hello-unknown-
> kalimba_arch4-kcc-36
> ===================================================================
> --- test/functionalities/object-file/bin/hello-unknown-kalimba_arch4-kcc-36
> (revision 0)
> +++ test/functionalities/object-file/bin/hello-unknown-kalimba_arch4-kcc-36
> (working copy)
>
> Property changes on: test/functionalities/object-file/bin/hello-unknown-
> kalimba_arch4-kcc-36
> ___________________________________________________________________
> Added: svn:executable
> ## -0,0 +1 ##
> +*
> \ No newline at end of property
> Added: svn:mime-type
> ## -0,0 +1 ##
> +application/x-executable
> \ No newline at end of property
> Index: test/functionalities/object-file/bin/hello.c
> ===================================================================
> --- test/functionalities/object-file/bin/hello.c        (revision 0)
> +++ test/functionalities/object-file/bin/hello.c        (working copy)
> @@ -0,0 +1,8 @@
> +#include <stdio.h>
> +
> +int main(int argc, char **argv)
> +{
> +       printf("Hello, world\n");
> +       return 0;
> +}
> +
>
>
>
> Member of the CSR plc group of companies. CSR plc registered in England
> and Wales, registered number 4187346, registered office Churchill House,
> Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
> More information can be found at www.csr.com. Keep up to date with CSR on
> our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people,
> YouTube, www.youtube.com/user/CSRplc, Facebook,
> www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at
> www.twitter.com/CSR_plc.
> New for 2014, you can now access the wide range of products powered by
> aptX at www.aptx.com.
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140723/ce6b464a/attachment.html>