<div dir="ltr">I'll have a look at this now. If I can run the test successfully, I'll get it in.<div><br></div><div>Thanks for zipping the object code, I'm sure that'll make this easier :-)</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Jul 23, 2014 at 4:50 AM, Matthew Gardiner <span dir="ltr"><<a href="mailto:mg11@csr.com" target="_blank">mg11@csr.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi folks,<br>
<br>
Since I have recently added CSR's kalimba as an architecture to lldb, we thought it would be wise to enhance TestImageListMultiArchitecture to check that kalimba ELFs are identified correctly to avoid any regression.<br>
<br>
I'm uploading a patch to add this test functionality.<br>
<br>
In addition to modifying the .py file, I'm adding a .c file since the kalimba compiler (kcc) does not support C++. Additionally I'm attaching a gzipped ELF since I'm not convinced that "svn di" is capable of building my added binary into the patch file.<br>
<br>
Could someone please submit my patch if it seems ok?<br>
<br>
thanks Matt<br>
<br>
Index: test/functionalities/object-<u></u>file/<u></u>TestImageListMultiArchitecture<u></u>.py<br>
==============================<u></u>==============================<u></u>=======<br>
--- test/functionalities/object-<u></u>file/<u></u>TestImageListMultiArchitecture<u></u>.py (revision 213650)<br>
+++ test/functionalities/object-<u></u>file/<u></u>TestImageListMultiArchitecture<u></u>.py (working copy)<br>
@@ -27,6 +27,7 @@<br>
"hello-netbsd-6.1-x86_64-gcc-<u></u>4.5.3": re.compile(r"x86_64-(unknown)?<u></u>-netbsd x86_64"),<br>
"hello-ubuntu-14.04-x86_64-<u></u>gcc-4.8.2": re.compile(r"x86_64-(unknown)?<u></u>-linux x86_64"),<br>
"hello-ubuntu-14.04-x86_64-<u></u>clang-3.5pre": re.compile(r"x86_64-(unknown)?<u></u>-linux x86_64"),<br>
+ "hello-unknown-kalimba_arch4-<u></u>kcc-36": re.compile(r"kalimba-csr-<u></u>unknown kalimba"),<br>
}<br>
<br>
for image_name in images:<br>
Index: test/functionalities/object-<u></u>file/bin/hello-unknown-<u></u>kalimba_arch4-kcc-36<br>
==============================<u></u>==============================<u></u>=======<br>
Cannot display: file marked as a binary type.<br>
svn:mime-type = application/x-executable<br>
Index: test/functionalities/object-<u></u>file/bin/hello-unknown-<u></u>kalimba_arch4-kcc-36<br>
==============================<u></u>==============================<u></u>=======<br>
--- test/functionalities/object-<u></u>file/bin/hello-unknown-<u></u>kalimba_arch4-kcc-36 (revision 0)<br>
+++ test/functionalities/object-<u></u>file/bin/hello-unknown-<u></u>kalimba_arch4-kcc-36 (working copy)<br>
<br>
Property changes on: test/functionalities/object-<u></u>file/bin/hello-unknown-<u></u>kalimba_arch4-kcc-36<br>
______________________________<u></u>______________________________<u></u>_______<br>
Added: svn:executable<br>
## -0,0 +1 ##<br>
+*<br>
\ No newline at end of property<br>
Added: svn:mime-type<br>
## -0,0 +1 ##<br>
+application/x-executable<br>
\ No newline at end of property<br>
Index: test/functionalities/object-<u></u>file/bin/hello.c<br>
==============================<u></u>==============================<u></u>=======<br>
--- test/functionalities/object-<u></u>file/bin/hello.c (revision 0)<br>
+++ test/functionalities/object-<u></u>file/bin/hello.c (working copy)<br>
@@ -0,0 +1,8 @@<br>
+#include <stdio.h><br>
+<br>
+int main(int argc, char **argv)<br>
+{<br>
+ printf("Hello, world\n");<br>
+ return 0;<br>
+}<br>
+<br>
<br>
<br>
<br>
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom<br>
More information can be found at <a href="http://www.csr.com" target="_blank">www.csr.com</a>. Keep up to date with CSR on our technical blog, <a href="http://www.csr.com/blog" target="_blank">www.csr.com/blog</a>, CSR people blog, <a href="http://www.csr.com/people" target="_blank">www.csr.com/people</a>, YouTube, <a href="http://www.youtube.com/user/CSRplc" target="_blank">www.youtube.com/user/CSRplc</a>, Facebook, <a href="http://www.facebook.com/pages/CSR/191038434253534" target="_blank">www.facebook.com/pages/CSR/<u></u>191038434253534</a>, or follow us on Twitter at <a href="http://www.twitter.com/CSR_plc" target="_blank">www.twitter.com/CSR_plc</a>.<br>
New for 2014, you can now access the wide range of products powered by aptX at <a href="http://www.aptx.com" target="_blank">www.aptx.com</a>.<br>
<br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>