[Lldb-commits] [PATCH] Add Host::GetMaxThreadNameLength(), modify private state thread name

[Todd Fiala]

This went up here:

svn commit
Sending        include/lldb/Host/Host.h
Sending        source/Host/common/Host.cpp
Sending        source/Target/Process.cpp
Transmitting file data ...
Committed revision 213183.



On Wed, Jul 16, 2014 at 10:09 AM, Todd Fiala <todd.fiala at gmail.com> wrote:

> Please find attached an adjusted patch.  It uses a const static member
> variable initialized properly in place of a function call.
>
> Tested:
> Linux Ubuntu 14.04 x86_64, clang-3.5-built lldb, all tests pass.
> MacOSX 10.9.4, Xcode 6.0 Beta 3-built lldb, all tests pass.
>
>
> On Sat, Jul 12, 2014 at 3:21 PM, Todd Fiala <tfiala at google.com> wrote:
>
>> Well, we can keep it simple until proven needed to be more complex :-)
>>  I'll switch it to a constant and re-send.
>>
>>
>> On Saturday, July 12, 2014, Ed Maste <emaste at freebsd.org> wrote:
>>
>>> On 11 July 2014 11:56, Todd Fiala <todd.fiala at gmail.com> wrote:
>>> > My take was it depends on host details.  For example, I didn't track
>>> down
>>> > the Windows way of getting this data, but I wouldn't be surprised if it
>>> > turned into a method call to the system (which could be cached, but
>>> that's
>>> > an impl detail that a method call would allow us to hide).
>>> >
>>> > I thought it made it more flexible on unknown details for
>>> current/future
>>> > platforms to have it be a function call.
>>>
>>> Fair enough, and it's not a big deal - I just assume it will in
>>> general be a (possibly empirically determined) constant.
>>>
>>> I did a little digging and couldn't find a limit for Windows.  I did
>>> discover the convoluted method used to set the thread name though:
>>> http://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>>
>>
>>
>> --
>> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>>
>>
>
>
> --
> -Todd
>



-- 
-Todd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140716/5d36f734/attachment.html>