<div dir="ltr">This went up here:<div><br></div><div><div>svn commit</div><div>Sending include/lldb/Host/Host.h</div><div>Sending source/Host/common/Host.cpp</div><div>Sending source/Target/Process.cpp</div>
<div>Transmitting file data ...</div><div>Committed revision 213183.</div></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 16, 2014 at 10:09 AM, Todd Fiala <span dir="ltr"><<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Please find attached an adjusted patch. It uses a const static member variable initialized properly in place of a function call.<div>
<br></div><div>Tested:</div><div>Linux Ubuntu 14.04 x86_64, clang-3.5-built lldb, all tests pass.</div>
<div>MacOSX 10.9.4, Xcode 6.0 Beta 3-built lldb, all tests pass.</div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Sat, Jul 12, 2014 at 3:21 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Well, we can keep it simple until proven needed to be more complex :-) I'll switch it to a constant and re-send.<div>
<div><span></span><br><br>On Saturday, July 12, 2014, Ed Maste <<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On 11 July 2014 11:56, Todd Fiala <<a>todd.fiala@gmail.com</a>> wrote:<br>
> My take was it depends on host details. For example, I didn't track down<br>
> the Windows way of getting this data, but I wouldn't be surprised if it<br>
> turned into a method call to the system (which could be cached, but that's<br>
> an impl detail that a method call would allow us to hide).<br>
><br>
> I thought it made it more flexible on unknown details for current/future<br>
> platforms to have it be a function call.<br>
<br>
Fair enough, and it's not a big deal - I just assume it will in<br>
general be a (possibly empirically determined) constant.<br>
<br>
I did a little digging and couldn't find a limit for Windows. I did<br>
discover the convoluted method used to set the thread name though:<br>
<a href="http://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx" target="_blank">http://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx</a><br></div></div>
_______________________________________________<br>
lldb-commits mailing list<br>
<a>lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><span><font color="#888888"><br>
</font></span></blockquote><span><font color="#888888"><br><br>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div dir="ltr">-Todd</div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">-Todd</div>
</div>