[Lldb-commits] [PATCH] Corrections for docs/lldb-gdb-remote.txt

[Todd Fiala]

Hey Matthew,

> 1. I've changed the base of cputype and cpusubtype to reflect the fact
that the code assumes base-16, and furthermore to be consistent with
qProcessInfo.

I'm looking at the debugserver code (RNBRemote.cpp) and lldb-platform/llgs
code (GDBRemoteCommunicationServer.cpp) that produce those values.  The
cputype and cpusubtype all are being written decimal as far as a I read it.
 What context are you seeing hexadecimal?

Thanks!

-Todd


On Wed, Jun 11, 2014 at 4:15 AM, Matthew Gardiner <mg11 at csr.com> wrote:

> Hi,
>
> I've made a couple of corrections to the documentation of the qHostInfo
> packet.
>
> 1. I've changed the base of cputype and cpusubtype to reflect the fact
> that the code assumes base-16, and furthermore to be consistent with
> qProcessInfo.
>
> 2. I've also added a description for "arch" which is parsed from the
> response, but was missing from the document.
>
> Could someone please apply my patch?
>
> thanks
> Matt
>
> (Patch attached)
>
> Index: docs/lldb-gdb-remote.txt
> ===================================================================
> --- docs/lldb-gdb-remote.txt    (revision 210650)
> +++ docs/lldb-gdb-remote.txt    (working copy)
> @@ -523,10 +523,11 @@
>
>  Key value pairs are one of:
>
> -cputype: is a number that is the mach-o CPU type that is being debugged
> (base 10)
> -cpusubtype: is a number that is the mach-o CPU subtype type that is being
> debugged (base 10)
> +cputype: is a number that is the mach-o CPU type that is being debugged
> (base 16)
> +cpusubtype: is a number that is the mach-o CPU subtype type that is being
> debugged (base 16)
>  triple: a string for the target triple (x86_64-apple-macosx) that can be
> used to specify arch + vendor + os in one entry
>  vendor: a string for the vendor (apple), not needed if "triple" is
> specified
> +arch: a string for the architecture being debugged (i386, x86_64,
> unknown), not needed if "triple" is specified
>  ostype: a string for the OS being debugged (darwin, linux, freebsd), not
> needed if "triple" is specified
>  endian: is one of "little", "big", or "pdp"
>  ptrsize: an unsigned number that represents how big pointers are in bytes
> on the debug target
>
>
>
> Member of the CSR plc group of companies. CSR plc registered in England
> and Wales, registered number 4187346, registered office Churchill House,
> Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
> More information can be found at www.csr.com. Keep up to date with CSR on
> our technical blog, www.csr.com/blog, CSR people blog, www.csr.com/people,
> YouTube, www.youtube.com/user/CSRplc, Facebook,
> www.facebook.com/pages/CSR/191038434253534, or follow us on Twitter at
> www.twitter.com/CSR_plc.
> New for 2014, you can now access the wide range of products powered by
> aptX at www.aptx.com.
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140611/518747d5/attachment.html>