[Lldb-commits] [PATCH] Make methods of exported API classes that access internal types private.
tfiala at google.com
Wed May 28 09:58:02 PDT 2014
I'm going to give it a build/test run and can check in after that. D3929
needs to go in first so I'll be looking at that one next, then this one.
On Wed, May 28, 2014 at 9:55 AM, Greg Clayton <gclayton at apple.com> wrote:
> Looks good.
> > On May 27, 2014, at 5:46 PM, Zachary Turner <zturner at google.com> wrote:
> > Hi tfiala,
> > As part of the contract of a dll-exported C++ interface, classes that
> are not exported should not be accessible via a public interface of an
> exported class, and doing so generates warnings on MSVC. These warnings
> can be safely suprressed as long as all non-exported classes are part of
> the exported class's private interface, so this change moves all such
> methods to the private interface, friending where necessary, and finally
> suppresses the warnings on MSVC.
> > http://reviews.llvm.org/D3934
> > Files:
> > CMakeLists.txt
> > include/lldb/API/SBDebugger.h
> > include/lldb/API/SBFrame.h
> > include/lldb/API/SBProcess.h
> > include/lldb/API/SBQueueItem.h
> > include/lldb/API/SBTarget.h
> > include/lldb/API/SBThread.h
> > include/lldb/API/SBValue.h
> > include/lldb/API/SBWatchpoint.h
> > source/API/SBDebugger.cpp
> > <D3934.9856.patch>_______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits