[Lldb-commits] [PATCH] Don't try to guess sys header conditions, and simply check if each signal is defined.

[Greg Clayton]

Looks good.

On Dec 12, 2013, at 4:04 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:

> http://llvm-reviews.chandlerc.com/D2394
> 
> Files:
>  source/Host/common/Host.cpp
> 
> Index: source/Host/common/Host.cpp
> ===================================================================
> --- source/Host/common/Host.cpp
> +++ source/Host/common/Host.cpp
> @@ -490,10 +490,10 @@
>     case SIGILL:    return "SIGILL";    // 4    illegal instruction (not reset when caught)
>     case SIGTRAP:   return "SIGTRAP";   // 5    trace trap (not reset when caught)
>     case SIGABRT:   return "SIGABRT";   // 6    abort()
> -#if  (defined(_POSIX_C_SOURCE) && !defined(_DARWIN_C_SOURCE))
> +#if  defined(SIGPOLL)
>     case SIGPOLL:   return "SIGPOLL";   // 7    pollable event ([XSR] generated, not supported)
> #endif
> -#if  !defined(_POSIX_C_SOURCE)
> +#if  defined(SIGEMT)
>     case SIGEMT:    return "SIGEMT";    // 7    EMT instruction
> #endif
>     case SIGFPE:    return "SIGFPE";    // 8    floating point exception
> @@ -511,15 +511,17 @@
>     case SIGCHLD:   return "SIGCHLD";   // 20    to parent on child stop or exit
>     case SIGTTIN:   return "SIGTTIN";   // 21    to readers pgrp upon background tty read
>     case SIGTTOU:   return "SIGTTOU";   // 22    like TTIN for output if (tp->t_local&LTOSTOP)
> -#if  !defined(_POSIX_C_SOURCE)
> +#if  defined(SIGIO)
>     case SIGIO:     return "SIGIO";     // 23    input/output possible signal
> #endif
>     case SIGXCPU:   return "SIGXCPU";   // 24    exceeded CPU time limit
>     case SIGXFSZ:   return "SIGXFSZ";   // 25    exceeded file size limit
>     case SIGVTALRM: return "SIGVTALRM"; // 26    virtual time alarm
>     case SIGPROF:   return "SIGPROF";   // 27    profiling time alarm
> -#if  !defined(_POSIX_C_SOURCE)
> +#if  defined(SIGWINCH)
>     case SIGWINCH:  return "SIGWINCH";  // 28    window size changes
> +#endif
> +#if  defined(SIGINFO)
>     case SIGINFO:   return "SIGINFO";   // 29    information request
> #endif
>     case SIGUSR1:   return "SIGUSR1";   // 30    user defined signal 1
> <D2394.1.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits