[Lldb-commits] [lldb] r196610 - Fixed the GDBRemoteCommuncation to return a new GDBRemoteCommuncation::PacketResult enum for all packet sends/receives.

[Greg Clayton]

On Dec 9, 2013, at 1:42 PM, Ed Maste <emaste at freebsd.org> wrote:

>> Due to other recent changes, all connections to GDB servers that didn't support the "QStartNoAckMode" packet would cause us to fail to attach to the remote GDB server.
>> 
>> The problem was that SendPacket* and WaitForResponse* packets would return a size_t indicating the number of bytes sent/received. The other issue was WaitForResponse* packets would strip the leading '$' and the trailing "#CC" (checksum) bytes, so the unimplemented response packet of "$#00" would get stripped and the WaitForResponse* packets would return 0.
>> 
>> These new error codes give us flexibility to to more intelligent things in response to what is returned.
> 
> Hi Greg,
> 
> Am I correct that this is to allow for better error handling in a
> subsequent change, but does not address the actual failure with GDB
> protocol targets lacking QStartNoAckMode?

This actually does fix attaching to GDB servers that don't support QStartNoAckMode and was the main reason for making this fix!

Greg