[Lldb-commits] [lldb] r189934 - Remove <windows.h> from lldb-types.h.

Malea, Daniel daniel.malea at intel.com
Thu Sep 5 08:31:56 PDT 2013

The patch seems pretty reasonable Virgile, thank you getting on top of this!

I can confirm it fixes the unit tests I mentioned earlier. Please commit it at your leisure :)


From: Virgile Bello <virgile.bello at gmail.com<mailto:virgile.bello at gmail.com>>
Date: Thursday, 5 September, 2013 8:48 AM
To: "jingham at apple.com<mailto:jingham at apple.com>" <jingham at apple.com<mailto:jingham at apple.com>>
Cc: Daniel Malea <daniel.malea at intel.com<mailto:daniel.malea at intel.com>>, "lldb-commits at cs.uiuc.edu<mailto:lldb-commits at cs.uiuc.edu>" <lldb-commits at cs.uiuc.edu<mailto:lldb-commits at cs.uiuc.edu>>
Subject: Re: [Lldb-commits] [lldb] r189934 - Remove <windows.h> from lldb-types.h.

Here is a patch to use std::atomic.
Removed RefCounter.h/cpp since not used anymore as well (it would need atomic anyway).

If it looks good to you, I will commit asap to fix the build.
Sorry again that I didn't know LLVM headers could not be used from LLDB headers.

On Thu, Sep 5, 2013 at 6:40 PM, Virgile Bello <virgile.bello at gmail.com<mailto:virgile.bello at gmail.com>> wrote:
I see, sorry about that.
I will fix it by adding the atomic stuff in lldb/Host then.

On Thu, Sep 5, 2013 at 8:56 AM, <jingham at apple.com<mailto:jingham at apple.com>> wrote:
Yes, I agree with this part.  It should not be necessary to have the LLVM headers around to build programs that only use the lldb SB API's.


On Sep 4, 2013, at 4:36 PM, Malea, Daniel <daniel.malea at intel.com<mailto:daniel.malea at intel.com>> wrote:

> This commit introduces a dependency in the LLDB API on the LLVM headers,
> which is not ideal because users of the LLDB API shouldn't be required to
> have LLVM headers around IMHO.

More information about the lldb-commits mailing list