[Lldb-commits] [lldb] r189934 - Remove <windows.h> from lldb-types.h.

Virgile Bello virgile.bello at gmail.com
Thu Sep 5 05:48:47 PDT 2013

Here is a patch to use std::atomic.
Removed RefCounter.h/cpp since not used anymore as well (it would need
atomic anyway).

If it looks good to you, I will commit asap to fix the build.
Sorry again that I didn't know LLVM headers could not be used from LLDB

On Thu, Sep 5, 2013 at 6:40 PM, Virgile Bello <virgile.bello at gmail.com>wrote:

> I see, sorry about that.
> I will fix it by adding the atomic stuff in lldb/Host then.
> On Thu, Sep 5, 2013 at 8:56 AM, <jingham at apple.com> wrote:
>> Yes, I agree with this part.  It should not be necessary to have the LLVM
>> headers around to build programs that only use the lldb SB API's.
>> Jim
>> On Sep 4, 2013, at 4:36 PM, Malea, Daniel <daniel.malea at intel.com> wrote:
>> > This commit introduces a dependency in the LLDB API on the LLVM headers,
>> > which is not ideal because users of the LLDB API shouldn't be required
>> to
>> > have LLVM headers around IMHO.
>> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130905/dd8c2d70/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lldb-atomic.patch
Type: application/octet-stream
Size: 9313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130905/dd8c2d70/attachment.obj>

More information about the lldb-commits mailing list