[Lldb-commits] REVIEW: Compile and sign debugserver binary using the Makefiles

[Charles Davis]

On Apr 4, 2013, at 3:34 PM, Filipe Cabecinhas wrote:

> Hi all,
> 
> I've changed the Makefiles around to compile the debugserver binary using them.
So did I ;).
> I moved debugserver.cpp and debugserver-entitlements.plist from source/... onto driver/...
I think this is a good idea. Wish I'd thought of that...

Later on, maybe we can make this a normal LLDB library, and/or split it into several different libraries.
> and created a makefile there that will create the debugserver tool and sign it (Not with the correct signature for now, but I have a patch for llvm's makefiles to correct it).
I have my own patch for that issue, too. I really should've piped up earlier :). I also have some other patches to the LLVM build system that I really need to get upstreamed, including one that adds support for assembly source files.
> 
> I fixed the references I could find for those two files in the Xcode project file (both on the project files and on the entitlements for debugserver on iOS).
> 
> I brought in generate-vers.pl from lldb/scripts to create debugserver_vers.c for Mac OS X (we could in the future abstract the script and keep only one copy, or use the same version numbering as clang and lldb-linux).
IMO, unless we're being built Apple-style (i.e. with the Xcode project), we really should use the same versioning scheme as Clang and LLDB on Linux. But that's just my opinion.
> 
> I also added Makefiles for the subdirectories under debugserver/source, of course.
> 
> Apple folks: Could you check out the xcodeproj files and confirm that everything is okay with you?
> Linux/FreeBSD/others: Please test it to see what changes may be needed to not break the build. I'm thinking about only including debugserver in DIRS if uname -s is Darwin.
That's what I did in mine.

Hang on, maybe I can see about putting our patches together. Mine has some other stuff (e.g. dependency tracking for the MIG source, universal build support) that yours doesn't have.

Chip

> <lldb-makefiles.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130404/4794680a/attachment.html>