[Lldb-commits] [lldb] r175842 - Ignore the check for com.apple.main-thread - it is not critical for the test case's logic

[Enrico Granata]

Very fair call. I misread the line as if it said log_lines = [x for x in expected_log_lines] (i.e. check that the log we get is the log we expect) versus what it really says.
Feel free to remove

Enrico Granata
✉ egranata@.com
✆ 27683

On Feb 21, 2013, at 4:47 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> On Fri, Feb 22, 2013 at 2:39 AM, Enrico Granata <egranata at apple.com> wrote:
>> Author: enrico
>> Date: Thu Feb 21 18:39:53 2013
>> New Revision: 175842
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=175842&view=rev
>> Log:
>> Ignore the check for com.apple.main-thread - it is not critical for the test case's logic
>> 
>> 
>> Modified:
>>    lldb/trunk/test/logging/TestLogging.py
>> 
>> Modified: lldb/trunk/test/logging/TestLogging.py
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/logging/TestLogging.py?rev=175842&r1=175841&r2=175842&view=diff
>> ==============================================================================
>> --- lldb/trunk/test/logging/TestLogging.py (original)
>> +++ lldb/trunk/test/logging/TestLogging.py Thu Feb 21 18:39:53 2013
>> @@ -63,9 +63,8 @@ class LogTestCase(TestBase):
>>             "HandleCommand, command succeeded\n",
>>             ]
>> 
>> -        # com.apple.main-thread identifier appears on darwin only
>>         if sys.platform.startswith("darwin"):
>> -            expected_log_lines = ['com.apple.main-thread ' + x for x in expected_log_lines]
>> +            expected_log_lines = [x for x in expected_log_lines]
> 
> This 'if' looks like a no-op now.
> 
> Dmitri
> 
> -- 
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130221/6e8d5f30/attachment.html>