<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Very fair call. I misread the line as if it said log_lines = [x for x in expected_log_lines] (i.e. check that the log we get is the log we expect) versus what it really says.<div>Feel free to remove</div><div><br><div>
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="font-size: medium; orphans: 2; widows: 2; border-collapse: separate; border-spacing: 0px;"><span style="font-size: 12px; orphans: auto; widows: auto;">Enrico Granata</span><br style="font-size: 12px; orphans: auto; widows: auto;"><span style="font-size: 12px; orphans: auto; widows: auto;">✉ egranata@</span><font color="#ff2600" style="font-size: 12px; orphans: auto; widows: auto;"></font><span style="font-size: 12px; orphans: auto; widows: auto;">.com</span><br style="font-size: 12px; orphans: auto; widows: auto;"><span style="font-size: 12px; orphans: auto; widows: auto;">✆ 27683</span></div></div>
</div>
<br><div><div>On Feb 21, 2013, at 4:47 PM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Fri, Feb 22, 2013 at 2:39 AM, Enrico Granata <<a href="mailto:egranata@apple.com">egranata@apple.com</a>> wrote:<br><blockquote type="cite">Author: enrico<br>Date: Thu Feb 21 18:39:53 2013<br>New Revision: 175842<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175842&view=rev">http://llvm.org/viewvc/llvm-project?rev=175842&view=rev</a><br>Log:<br>Ignore the check for com.apple.main-thread - it is not critical for the test case's logic<br><br><br>Modified:<br>    lldb/trunk/test/logging/TestLogging.py<br><br>Modified: lldb/trunk/test/logging/TestLogging.py<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/logging/TestLogging.py?rev=175842&r1=175841&r2=175842&view=diff">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/logging/TestLogging.py?rev=175842&r1=175841&r2=175842&view=diff</a><br>==============================================================================<br>--- lldb/trunk/test/logging/TestLogging.py (original)<br>+++ lldb/trunk/test/logging/TestLogging.py Thu Feb 21 18:39:53 2013<br>@@ -63,9 +63,8 @@ class LogTestCase(TestBase):<br>             "HandleCommand, command succeeded\n",<br>             ]<br><br>-        # com.apple.main-thread identifier appears on darwin only<br>         if sys.platform.startswith("darwin"):<br>-            expected_log_lines = ['com.apple.main-thread ' + x for x in expected_log_lines]<br>+            expected_log_lines = [x for x in expected_log_lines]<br></blockquote><br>This 'if' looks like a no-op now.<br><br>Dmitri<br><br>-- <br>main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>>*/<br></blockquote></div><br></div></body></html>