[Lldb-commits] [lldb] r169409 - /lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp

Greg Clayton gclayton at apple.com
Wed Dec 5 11:43:20 PST 2012


Author: gclayton
Date: Wed Dec  5 13:43:20 2012
New Revision: 169409

URL: http://llvm.org/viewvc/llvm-project?rev=169409&view=rev
Log:
Backed out part of the ABI changes that were checked in because it breaks the i386 test suite as it makes backtraces for the first instruction of a function fail. Stepping relies on backtraces being correct, so I am reverting what is causing the breakage.

I filed this to track the fix:

<rdar://problem/12817918> Recent i386 ABI changes break the i386 test suite because stack backtracing is busted when stopped in trampolines



Modified:
    lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp

Modified: lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp?rev=169409&r1=169408&r2=169409&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp (original)
+++ lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp Wed Dec  5 13:43:20 2012
@@ -945,7 +945,7 @@
             switch (name[1])
             {
             case 'b': 
-                if (name[2] == 'x' || name[2] == 'p')
+                if (name[2] == 'x')// || name[2] == 'p')
                     return name[3] == '\0';
                 break;
             case 'd':





More information about the lldb-commits mailing list