[Lldb-commits] [lldb-commits] [patch] [review request] Generalize host vendor and os reporting

Greg Clayton gclayton at apple.com
Fri Oct 12 09:17:43 PDT 2012

Looks good

% svn commit source/Host/common/Host.cpp
Sending        source/Host/common/Host.cpp
Transmitting file data .
Committed revision 165805.

On Oct 9, 2012, at 4:30 PM, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:

> We came across a problem on Linux where target matching wasn’t working because the vendor was being reported as ‘gnu’ instead of ‘pc’.  Looking at the code, it seems that the vendor being reported for both Linux and FreeBSD was invalid.  The OS strings, while OK, were also hard-coded where they didn’t need to be.  The attached patch removes ifdef’s so that all cases use the host triple.
> This problem is orthogonal to the patch I submitted last week to work around an inappropriate default triple on Linux.  Both are needed.
> Thanks in advance for any review feedback.
> -Andy
> <host-vendor.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

More information about the lldb-commits mailing list