[Lldb-commits] [lldb] r159885 - /lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp

Sean Callanan scallanan at apple.com
Fri Jul 6 18:38:30 PDT 2012

Author: spyffe
Date: Fri Jul  6 20:38:30 2012
New Revision: 159885

URL: http://llvm.org/viewvc/llvm-project?rev=159885&view=rev
On i386 we see occasional crashes when the register
context is not returning valid registers yet.  Don't
crash in these situations.



Modified: lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp?rev=159885&r1=159884&r2=159885&view=diff
--- lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp (original)
+++ lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp Fri Jul  6 20:38:30 2012
@@ -272,6 +272,8 @@
     // the actual register it pertains to is not important, just the size needs 
     // to be correct. Here we use "eax"...
     const RegisterInfo *reg_info_32 = reg_ctx->GetRegisterInfoByName("eax");
+    if (!reg_info_32)
+        return false; // TODO this should actually never happen
     // Make room for the argument(s) on the stack

More information about the lldb-commits mailing list